Autocomplete: reopen @-mention suggestions when backspacing inside formatted mentions #2040
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted mentions Match web behavior by reopening mention autocomplete when backspacing inside formatted mentions like @**Name**. Update model and widget tests to reflect the new autocomplete lifecycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the @-mention autocomplete behavior to match the web app.
When a user backspaces inside a formatted mention (e.g.
@**Chris Bobbe**),the autocomplete is now reopened by stripping the formatting and re-evaluating
the mention query, instead of suppressing autocomplete entirely.
As part of this change:
before matching.
inside formatted mentions.
autocomplete UI, which is now unmounted when no valid intent exists
instead of remaining visible with empty results.
pending timers at teardown.
Screenshots attached show the behavior before and after this change.
Before: Backspacing inside a formatted mention does not reopen autocomplete.
After: Autocomplete reopens correctly, matching web behavior.
Fixes #1967