check: Update the flutter_version check to follow upstream #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hmm CI is failing, could you take a look? |
rajveermalviya
force-pushed
the
pr-flutter-version-check
branch
from
5f5471e to
fd5eb30
Compare
Collaborator
|
Hmm looks like CI is failing again. |
See:
https://github.com/actions/checkout/blob/8e8c483db/action.yml#L74-L76
Without this change, the main branch is not fetched when the
current branch is non-main. We need this because soon we will run
the `flutter_version` suite in CI only when there are changes in
`pubspec.yaml` or `tools/check` files. For that, we need the `main`
branch to be able to calculate the file diff.
Otherwise the suite will fail when calling `git_base_commit` saying:
fatal: Not a valid object name refs/remotes/origin/main
Flutter's new versioning depends on the latest tag pushed upstream. And we are going to add the check for Flutter version string back soon. To avoid frequent CI failures that may be caused by a new tag being pushed upstream, run the flutter_version check in CI only when there are changes in the `pubspec.yaml` or `tools/check` files.
Since flutter/flutter@e45fd36aa the flutter tool now uses a combination of git commands, instead of using the result of `git describe` to generate the version string. So, we update the check to use the same commands here, and then do some transformations to match the string from the flutter tool: https://github.com/flutter/flutter/blob/9f383e099/packages/flutter_tools/lib/src/version.dart#L1162 Fixes: zulip#1851
rajveermalviya
force-pushed
the
pr-flutter-version-check
branch
from
fd5eb30 to
5389e66
Compare
rajveermalviya
added
the
maintainer review
Member
Author
|
@chrisbobbe This PR is ready for review now, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #2009
Since flutter/flutter@e45fd36aa the flutter tool now uses a combination of git commands, instead of using the result of
git describeto generate the version string.So, we update the check to use the same commands here, and then do some transformations to match the string from the flutter tool:
https://github.com/flutter/flutter/blob/9f383e099/packages/flutter_tools/lib/src/version.dart#L1162
Fixes: #1851