Add curve functions wrappers #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure why the CI is failing |
gummif
reviewed
Dec 10, 2025
| return public_key_buffer; | ||
| } | ||
|
|
||
| namespace z85 { |
Member
There was a problem hiding this comment.
z85 is not necessarily only used for curve, so I think I would prefer zmq::z85_endcode/z85_decode.
gummif
reviewed
Dec 10, 2025
|
|
||
| namespace curve { | ||
|
|
||
| inline std::pair<std::string, std::string> keypair() |
Member
There was a problem hiding this comment.
The style of the library would be to name these zmq::curve_keypair and zmq::curve_public.
gummif
reviewed
Dec 10, 2025
| char *buffer = new char[buffer_size]; | ||
| auto *result = zmq_z85_encode(buffer, data.data(), data.size()); | ||
| if (result == nullptr) | ||
| throw zmq::error_t(); |
Member
There was a problem hiding this comment.
This leaks memory.
Could do std::string dest(buffer_size - 1); and write to that directly.
gummif
reviewed
Dec 10, 2025
|
|
||
| inline std::vector<uint8_t> decode(const std::string& encoded) | ||
| { | ||
| size_t dest_size = static_cast<double>(encoded.size()) * 0.8; |
Member
There was a problem hiding this comment.
I am a bit afraid of these floating point computations here and in encode.
What about (encoded.size() * size_t{4}) / size_t{5}?
Member
|
Could you try bumping the C++ version of the gcc-9 test to gcc-11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670