Compat: Disable TypeScript PnP in browser environments #7012
+2,974
−2,594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure checks are run for updates to the patch scripts, not just the patches themselves
Gaiman's Law strikes again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
This is stacked on top of #7009. I'll rebase this when that PR is merged.
What's the problem this PR addresses?
Some functionality (e.g.
transpileModule) of TypeScript can run in browsers. However, out patched versions of TypeScript checks for PnP by accessingprocess.verions.pnp, which throws in browsers whereprocessis not defined as a global.Fixes #6944
How did you fix it?
This PR changes the PnP check to check for
typeof process !== 'undefined'before checkingprocess?.versions?.pnpChecklist