Skip to content

Conversation

@tumf
Copy link
Owner

@tumf tumf commented Sep 5, 2025

This PR fixes the failing GitHub Actions run by ensuring Codecov finds a coverage report.

Changes:

  • Makefile: generate coverage.xml via pytest --cov-report=xml and add --cov-report=term-missing
  • Makefile: remove embedded uv run from test/coverage targets to avoid double uv run; CI continues to call uv run make ...
  • uv.lock updated accordingly

Local verification:

  • make check: passed (ruff/black/isort/mypy)
  • make coverage: passed; coverage.xml generated

Expected result:

  • Test workflow succeeds
  • Codecov upload step no longer fails due to missing coverage.xml

wakumo-ai and others added 4 commits September 5, 2025 13:32
- Update Makefile coverage target to generate XML report for codecov
- Add --cov-report=xml flag for CodeCov integration
- Add --cov-report=term-missing for better local development feedback
- Simplify test command to use direct pytest execution

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Removes the -i (interactive) flag from shell command execution which can cause
issues in automated environments like CI/CD pipelines.
@codecov
Copy link

codecov bot commented Sep 5, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

wakumo-ai and others added 4 commits September 5, 2025 15:44
…xecutor

- Add ProcessManager tests for is_running attribute, cleanup_all behavior, timeout handling, and signal handling
- Add ShellExecutor tests for shell fallback, pipeline validation, command parsing errors, and IO redirection
- Improve test coverage for error handling paths and edge cases in both components

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Expand edge case testing in test_shell_executor_edge_cases.py
- Improve test coverage in test_process_manager_additional.py
- Add comprehensive test coverage in test_shell_executor_more_coverage.py
- Minor improvements to shell_executor.py for better testability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@tumf tumf merged commit 9a41d43 into main Sep 6, 2025
3 checks passed
@tumf tumf deleted the fix/gha-codecov-coverage-xml branch September 6, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants