Skip to content

Conversation

@amanfcp
Copy link
Contributor

@amanfcp amanfcp commented Dec 9, 2025

Description:

  • Switch from POST /tasks/search to GET /users/me endpoint for better reliability
  • Add strict email verification comparing API response against credentials
  • Refactor verification logic into verifyCopper() helper function
  • Properly cleanup response bodies to avoid resource leaks

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@amanfcp amanfcp requested a review from a team December 9, 2025 12:52
@amanfcp amanfcp requested a review from a team as a code owner December 9, 2025 12:52
@amanfcp amanfcp changed the title Ins 215 Improve Copper Detector verification with stricter status code and email matching Dec 9, 2025
Copy link
Contributor

@camgunz camgunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; gonna check before we merge this in though, so let's hold off on merging until then.

}

// strict verification with email in credentials
if respBody.Email == email {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we talking 🚀

If it still breaks - I am gonna 😠

@amanfcp amanfcp merged commit 7583da5 into main Dec 9, 2025
13 checks passed
@amanfcp amanfcp deleted the INS-215 branch December 9, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants