Skip to content

add vector length check for read_file_ functions. #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gguyver wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −0
Open

add vector length check for read_file_ functions. #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea5351
add vector length check for read_file_ functions.
gguyver Nov 24, 2025
73304b4
Apply suggestions from code review
gguyver Nov 24, 2025
de63cf0
fix tests
gguyver Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions R/source.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ datasource <- function(
comment = "",
skip_quote = TRUE
) {
if (length(file) == 0) {
stop("`file` vector length must be greater than 0", call. = FALSE)
}
if (inherits(file, "source")) {
# If `skip` and `comment` arguments are expliictly passed, we want to use
# those even if `file` is already a source
Expand Down
9 changes: 9 additions & 0 deletions tests/testthat/test-read-file.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ test_that("read_file returns \"\" on an empty file", {
expect_equal(read_file(test_path("empty-file")), "")
})

test_that("read_file errors when provided an empty vector", {
expect_error(read_file(raw()))
expect_error(read_file(numeric()))
})
# read_file_raw ---------------------------------------------------------------

test_that("read_file_raw works with a local text file", {
Expand All @@ -84,3 +88,8 @@ test_that("read_file_raw works with a character datasource", {
test_that("read_file_raw returns raw() on an empty file", {
expect_equal(read_file_raw(test_path("empty-file")), raw())
})

test_that("read_file_raw errors when provided an empty vector", {
expect_error(read_file_raw(raw()))
expect_error(read_file_raw(numeric()))
})