🐛(frontend) paste content with comments from another document #1732
+85
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/comments-copy-bug
branch
from
7d5f68d to
edc4f3d
Compare
|
Size Change: +149 B (0%) Total Size: 4.14 MB
|
Collaborator
Author
|
This #1733 save partially the problem as well, no crash anymore. |
When pasting comments, the data-bn-thread-id attribute is present in the clipboard data. This indicates that the pasted content contains comments. But if the content with comments comes from another document, it will create orphaned comments that are not linked to this document and create errors. To avoid this, we refresh the threads to ensure that only comments relevant to the current document are displayed.
AntoLC
force-pushed
the
fix/comments-copy-bug
branch
from
edc4f3d to
31bd475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See: #1680
When pasting comments, the
data-bn-thread-idattribute is present in the clipboard data.This indicates that the pasted content contains comments. But if the content with comments comes from another document, it will create orphaned comments that are not linked to this document and create errors.
Proposal
To avoid this, when a comment is pasted, we refresh the threads to ensure that only comments relevant to the current document are displayed.