🛂(backend) stop throttling collaboration servers #1730
+208
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observe some throttling pick here and there. We observed that when the collaboration has a problem, it is retrying to connect, leading to more requests to the django backend. At one point, the throttling is reached and the user would not be able to use the application anymore. Now when the request comes from a collaboration server, we do not throttle it anymore.
AntoLC
force-pushed
the
enhance/throttle-from-collab
branch
from
7371697 to
2d803f9
Compare
lunika
reviewed
Dec 15, 2025
| factories.UserDocumentAccessFactory(document=document, user=user) | ||
|
|
||
| # Make many requests with the y-provider API key | ||
| for _i in range(100): |
Member
There was a problem hiding this comment.
Maybe you can test with 10 ? To save time in the test suite
| f"/api/v1.0/documents/{document.id!s}/", | ||
| ) | ||
| assert response.status_code == 429 | ||
|
|
Member
There was a problem hiding this comment.
You can maybe here make a new request using the special header to test that this one will not be throttled ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We observe some throttling pick here and there.
We observed that when the collaboration has a problem, it is retrying to connect, leading to more requests to the django backend. At one point, the throttling is reached and the user would not be able to use the application anymore.
Proposal
Now when the request comes from a collaboration server, we do not throttle it anymore.
To do so we add the
Y_PROVIDER_API_KEYin the request coming from the collaboration server.