refactor: move security at inception ls #1043
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawkyZ
changed the title
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details | |
| Licenses | 0 | 0 | 0 | 0 | See details | |
| ✅ | Code Security | 0 | 0 | 0 | 0 | 0 issues |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
# Conflicts: # application/config/config.go # application/server/configuration_test.go
5 tasks
ShawkyZ
commented
Dec 9, 2025
ShawkyZ
commented
Dec 11, 2025
| c.engine = engine | ||
| } | ||
|
|
||
| c.engine.SetUserInterface(util.NewLsUserInterface(c.logger)) |
Collaborator
Author
There was a problem hiding this comment.
this is needed, since LS will use CLI UserInterface by default, which will always output to stdout which will break LS stdio stream
# Conflicts: # application/config/config.go # application/server/configuration.go # internal/types/lsp.go
ShawkyZ
commented
Dec 12, 2025
| isLSPInitialized bool | ||
| cachedOriginalPath string | ||
| userSettingsPath string | ||
| autoConfigureMcpEnabled bool |
Collaborator
Author
There was a problem hiding this comment.
make sure it's the same name
ShawkyZ
commented
Dec 12, 2025
| mcpConfig.Set(mcp.ToolNameParam, c.IdeName()) | ||
| mcpConfig.Set(mcp.IdeConfigPathParam, c.IdeName()) | ||
| mcpConfig.Set(mcp.TrustedFoldersParam, trustedFoldersStr) | ||
| if c.GetSecureAtInceptionExecutionFrequency() == "Smart Scan" { |
ShawkyZ
commented
Dec 12, 2025
| mcp "github.com/snyk/studio-mcp/shared" | ||
| ) | ||
|
|
||
| func CallMcpConfigWorkflow(c *config.Config, notifier notification.Notifier, configureMcp bool, configureRules bool) { |
Collaborator
Author
There was a problem hiding this comment.
this all must be a go routine
ShawkyZ
commented
Dec 12, 2025
| RequiredProtocolVersion string `json:"requiredProtocolVersion,omitempty"` | ||
| HoverVerbosity *int `json:"hoverVerbosity,omitempty"` | ||
| OutputFormat *string `json:"outputFormat,omitempty"` | ||
| AutoConfigureSnykMcpServer string `json:"autoConfigureSnykMcpServer,omitempty"` |
Collaborator
Author
There was a problem hiding this comment.
double check the name here
ShawkyZ
commented
Dec 12, 2025
| } | ||
|
|
||
| func NewLsUserInterface(logger *zerolog.Logger) *LsUserInterface { | ||
| return &LsUserInterface{ |
Collaborator
Author
There was a problem hiding this comment.
add handlers + options functions for output handler + input handler, error handler, progress handler, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Waiting on: snyk/studio-mcp#7
Checklist
make generate)make lint-fix)