missing_asserts_for_indexing: support comparing to const values
#16239
+220
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16237
I think current behavior is unsatisfying because comparing
v.len()withconstvalues inassert!()is pretty common (31.2k results on GitHub).This PR would make enabling this lint less painful in my opinion.
Example
changelog: [
missing_asserts_for_indexing]: support comparing toconstvalues