Use env bash in script/import-database-dump.sh

[Its-Just-Nans]

Related to #12492 (comment)

• https://www.shellcheck.net/wiki/SC3040

Other options is to use /bin/bash instead of /bin/sh

[Turbo87]

Thanks for the PR! You're correct that pipefail is not POSIX-compliant.

However, I'd prefer changing the shebang to #!/usr/bin/env bash instead of removing pipefail. The script has a pipeline on line 73:

python3 "$(dirname "$0")/infer-database-dump-version.py" -m "$DUMP_PATH/metadata.json" | psql -a "$DATABASE_NAME"

Without pipefail, if the Python script fails, psql might still exit 0 (having received partial or no input), and the script would continue silently. With pipefail, we'd catch this failure.

We already use bash in script/create-diff-link.sh, so there's precedent for it in this repo.

[Its-Just-Nans]

Okay thanks for the info

Fixed