Skip to content

feat: :include_task_supervisor #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ziinc wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: :include_task_supervisor #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
162ef64
Conditionally include Task.Supervisor in Supervisor.init
Ziinc Dec 4, 2025
e8719d9
Add include_task_supervisor option to scheduler
Ziinc Dec 4, 2025
226a710
Fix syntax for Enum.filter in supervisor.ex
Ziinc Dec 4, 2025
aea58db
chore: formatting
Ziinc Dec 4, 2025
8853414
docs: add :include_task_supervisor
Ziinc Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/quantum.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ defmodule Quantum do
* `:task_supervisor_name` - GenServer name of task supervisor \\
*(unstable, may break without major release until declared stable)*

* `:include_task_supervisor` - Include task supervisor in supervisor tree \\
*(unstable, may break without major release until declared stable)*

* `:timeout` - Sometimes, you may come across GenServer timeout errors
esp. when you have too many jobs or high load. The default `GenServer.call/3`
timeout is `5_000`.
Expand Down Expand Up @@ -290,6 +293,7 @@ defmodule Quantum do
|> Keyword.put_new(:name, scheduler)
|> update_in([:schedule], &Normalizer.normalize_schedule/1)
|> Keyword.put_new(:task_supervisor_name, Module.concat(scheduler, TaskSupervisor))
|> Keyword.put_new(:include_task_supervisor, true)
|> Keyword.put_new(:storage_name, Module.concat(scheduler, Storage))
|> Keyword.put_new(:task_registry_name, Module.concat(scheduler, TaskRegistry))
|> Keyword.put_new(:clock_broadcaster_name, Module.concat(scheduler, ClockBroadcaster))
Expand Down
6 changes: 4 additions & 2 deletions lib/quantum/supervisor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ defmodule Quantum.Supervisor do
storage: storage,
scheduler: ^scheduler,
task_supervisor_name: task_supervisor_name,
include_task_supervisor: include_task_supervisor,
storage_name: storage_name,
task_registry_name: task_registry_name,
clock_broadcaster_name: clock_broadcaster_name,
Expand Down Expand Up @@ -91,15 +92,16 @@ defmodule Quantum.Supervisor do

Supervisor.init(
[
{Task.Supervisor, task_supervisor_opts},
include_task_supervisor && {Task.Supervisor, task_supervisor_opts},
{storage, storage_opts},
{Quantum.ClockBroadcaster, clock_broadcaster_opts},
{Quantum.TaskRegistry, task_registry_opts},
{Quantum.JobBroadcaster, job_broadcaster_opts},
{Quantum.ExecutionBroadcaster, execution_broadcaster_opts},
{Quantum.NodeSelectorBroadcaster, node_selector_broadcaster_opts},
{Quantum.ExecutorSupervisor, executor_supervisor_opts}
],
]
|> Enum.filter(& &1),
strategy: :rest_for_one
)
end
Expand Down