Skip to content

decimal docs: specification link and examples #128698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 8 commits into from
Dec 16, 2025
Merged

decimal docs: specification link and examples #128698

hugovk merged 8 commits into from
Dec 16, 2025

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Jan 10, 2025 •
edited by github-actions bot
Loading

  • added a direct reference to a floating-point model used
  • and few examples for formatted string output

📚 Documentation preview 📚: https://cpython-previews--128698.org.readthedocs.build/

@skirpichev
decimal docs: specification link and examples
7a335ed 
* added a direct reference to a floating-point model used
* and few examples for formatted string output
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Jan 10, 2025
@skirpichev skirpichev mentioned this pull request Jan 10, 2025
Closed
rruuaanng
rruuaanng reviewed Jan 10, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
StanFromIreland
StanFromIreland approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

ericvsmith
ericvsmith reviewed Jan 23, 2025
View reviewed changes
@skirpichev skirpichev requested a review from ericvsmith January 24, 2025 02:39
@skirpichev
Copy link
Contributor Author

skirpichev commented Jan 24, 2025

@ericvsmith, refs to format/f-strings - added.

@ericvsmith
Copy link
Member

ericvsmith commented Jan 28, 2025

@ericvsmith, refs to format/f-strings - added.

I think that's good. It doesn't mention str.format, but that's not so important any more and I hope that anyone who really cares about it knows that it's all based on __format__.

@skirpichev
Copy link
Contributor Author

skirpichev commented Jan 28, 2025

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

@ericvsmith
Copy link
Member

ericvsmith commented Jan 29, 2025

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

Agreed.

@skirpichev skirpichev mentioned this pull request Apr 7, 2025
Merged
@skirpichev skirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@skirpichev skirpichev mentioned this pull request Jul 14, 2025
Closed
@skirpichev skirpichev requested a review from AA-Turner July 19, 2025 10:53
hugovk
hugovk reviewed Dec 16, 2025
View reviewed changes
@hugovk hugovk enabled auto-merge (squash) December 16, 2025 11:34
@hugovk hugovk merged commit 2450be6 into python:main Dec 16, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 16, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 16, 2025

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev @rruuaanng
@StanFromIreland @hugovk @miss-islington
decimal docs: specification link and examples (pythonGH-128698)
86d8e33 
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev @rruuaanng
@StanFromIreland @hugovk @miss-islington
decimal docs: specification link and examples (pythonGH-128698)
3a4b5b2 
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 16, 2025

GH-142804 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 16, 2025

GH-142805 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 16, 2025
@skirpichev skirpichev deleted the decimal-docs branch December 16, 2025 11:43
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington @skirpichev
@rruuaanng @StanFromIreland @hugovk
[3.14] decimal docs: specification link and examples (GH-128698) (#14…
ad6396e 
…2804)

decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington @skirpichev
@rruuaanng @StanFromIreland @hugovk
[3.13] decimal docs: specification link and examples (GH-128698) (#14…
e5fd737 
…2805)

decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

+1 more reviewer

@rruuaanng rruuaanng rruuaanng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev @ericvsmith @hugovk @StanFromIreland @rruuaanng @serhiy-storchaka