Skip to content

Conversation

@prateeks99
Copy link
Member

Description

Added Profile API tests.

Type of change

Migrated existing unittest to pytest.

How Has This Been Tested?

Test changes only.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 16, 2025
@prateeks99 prateeks99 requested a review from aosingh December 16, 2025 12:44
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 16, 2025
attribute_value="meta.llama-3.1-405b-instruct",
)
yield profile
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoke profile.delete() without try..except An unknown exception should fail the test.

)
attributes = await conversation.get_attributes()
assert attributes.title == f"{CONVERSATION_PREFIX}_NONE_DESC"
assert attributes.description is None No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline.

)
attrs = conv.get_attributes()
assert attrs.title == f"{CONVERSATION_PREFIX}_NONE_DESC"
assert attrs.description is None No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline. Please use pre-commit hooks to automatically fix all formatting on git commit

yield _create

for conv in created:
try:
Copy link
Member

@aosingh aosingh Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want unknown exceptions to be silently consumed. Any unknown exception should fail the test. Please remove try..except

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants