-
Notifications
You must be signed in to change notification settings - Fork 5
Adding Profile Tests #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
| attribute_value="meta.llama-3.1-405b-instruct", | ||
| ) | ||
| yield profile | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoke profile.delete() without try..except An unknown exception should fail the test.
| ) | ||
| attributes = await conversation.get_attributes() | ||
| assert attributes.title == f"{CONVERSATION_PREFIX}_NONE_DESC" | ||
| assert attributes.description is None No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline.
| ) | ||
| attrs = conv.get_attributes() | ||
| assert attrs.title == f"{CONVERSATION_PREFIX}_NONE_DESC" | ||
| assert attrs.description is None No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline. Please use pre-commit hooks to automatically fix all formatting on git commit
| yield _create | ||
|
|
||
| for conv in created: | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want unknown exceptions to be silently consumed. Any unknown exception should fail the test. Please remove try..except
Description
Added Profile API tests.
Type of change
Migrated existing unittest to pytest.
How Has This Been Tested?
Test changes only.
Checklist: