Fix/fs rmsync broken symlink 61020 #61040
Open
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
fs.rmSync()so it correctly removes broken symbolic links (and symlinks todirectories) instead of becoming a no-op or throwing
ERR_FS_EISDIR.Fixes: #61020
Details
rmSyncwas usingstd::filesystem::status(), which follows symlinks. Forbroken symlinks this reports
not_found, causingrmSyncto return earlywithout unlinking the symlink itself. Switching to
std::filesystem::symlink_status()makes
rmSyncoperate on the symlink entry, matchingfs.rm()behavior.Tests
./node test/parallel/test-fs-rm.js