Skip to content

Conversation

@Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Dec 13, 2025

Remove the ability to mutate signals constant as doing so can lead to unexpected behavior, notably when spawning child process.

Fixes: #44749

Remove the ability to mutate signals constant as doing so can lead to
unexpected behavior, notably when spawning child process.

Fixes: nodejs#44749
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Dec 13, 2025
@Xstoudi Xstoudi changed the title WIP os: freeze signals constant os: freeze signals constant Dec 13, 2025
@Xstoudi Xstoudi changed the title os: freeze signals constant WIP os: freeze signals constant Dec 13, 2025
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (81e05e1) to head (55ff2a1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61038      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         703      703              
  Lines      208538   208541       +3     
  Branches    40224    40221       -3     
==========================================
- Hits       184629   184606      -23     
- Misses      15912    15961      +49     
+ Partials     7997     7974      -23     
Files with missing lines Coverage Δ
lib/os.js 98.60% <100.00%> (+0.01%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent validation of custom signals

2 participants