Skip to content

tools: fix update-nghttp2 signature verification #61035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richardlau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: fix update-nghttp2 signature verification #61035

richardlau wants to merge 1 commit into from
+3 −2

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Dec 12, 2025

Detached signatures must be passed to gpgv as a filename before the datafile (which can be stdin but the detached signature file cannot be stdin and cannot be piped in).

Refs: #60113

The nghttp2 updater has been failing since #60113.
e.g. https://github.com/nodejs/node/actions/runs/19996542494/job/57344965958#step:6:11

Run ./tools/dep_updaters/update-nghttp2.sh > temp-output
gpgv: packet(2) with unknown version 96
gpgv: no signature found
gpgv: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
Error: Process completed with exit code 2.

@richardlau
tools: fix update-nghttp2 signature verification
89cca37 
Detached signatures must be passed to `gpgv` as a filename before
the datafile (which can be stdin but the detached signature file
cannot be stdin and cannot be piped in).
@richardlau richardlau added the tools Issues and PRs related to the tools directory. label Dec 12, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 12, 2025

Review requested:

  • @nodejs/security-wg

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau @nodejs-github-bot @lpinca @targos @cjihrig @marco-ippolito