Skip to content

Conversation

@GoldFish2500
Copy link

src: fix potential dereference null pointer

Pointer "control" doesn't check before usage in Replace function. There may be dereference null pointer.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Dec 12, 2025
@addaleax
Copy link
Member

@GoldFish2500 If there is a specific situation in which you are actually encountering a null pointer dereference, you'll need to do more than adding a DCHECK to avoid it.

Regardless of whether that is the case or not, contributions to V8 are submitted to their repository first: https://v8.dev/docs/contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants