Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Dec 7, 2025

Fixes: #60952

Reset prevRows for multiline prompts during tab completion so the refresh doesn’t wipe the completion list, and add a regression test
that simulates a multiline prompt to verify completions remain visible

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Dec 7, 2025
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (81e05e1) to head (e81bf43).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60981      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         703      703              
  Lines      208538   208541       +3     
  Branches    40224    40214      -10     
==========================================
- Hits       184629   184607      -22     
- Misses      15912    15953      +41     
+ Partials     7997     7981      -16     
Files with missing lines Coverage Δ
lib/internal/readline/interface.js 97.35% <100.00%> (+<0.01%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Han5991 Han5991 force-pushed the readline-multiline-completer branch 2 times, most recently from 1709dbc to e10f14b Compare December 11, 2025 13:04
@Han5991 Han5991 force-pushed the readline-multiline-completer branch from e10f14b to e81bf43 Compare December 13, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[readline] Multiline question eats the output from the completer

2 participants