Fix negative values breaking server launch in --reconnection-grace-time #282896
+62
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
--reconnection-grace-timeto a negative value (e.g.,-1000) causes the CLI parser to fail with "unexpected argument '-1' found".Changes
CLI argument parsing
reconnection_grace_timetype fromOption<u32>toOption<i32>incli/src/commands/args.rsandcli/src/tunnels/code_server.rsparseGraceTime()already handles negative values by falling back to defaultsTests
src/vs/server/test/node/serverEnvironmentService.test.tscovering negative, zero, empty, and invalid value handlingThe unsigned integer constraint at the CLI layer was premature - validation properly occurs in TypeScript where negative values are rejected with logging.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.