Fix terminal sticky scroll returning disposed commands after clearBuffer #282888
+51
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Terminal sticky scroll fails on second task run when
presentation.clear: trueis configured.getCommandForLine()returns disposed commands because it compares marker line numbers without checking validity—disposed markers haveline === -1, making-1 <= 0evaluate true.Changes
Modified
getCommandForLine()incommandDetectionCapability.ts:marker.line === -1(disposed afterclearBuffer())Added test coverage:
xterm.clear()Example
Related to #199305
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.