Auto approve most rg calls by default #282839
Draft
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds auto-approval support for ripgrep (rg) commands in the terminal chat agent tools, addressing issue #282824. The change allows most rg commands to be automatically approved while blocking potentially dangerous flags that could execute arbitrary code.
Key Changes
- Auto-approves
rg(ripgrep) commands by default - Blocks
rgcommands using--pre(preprocessor execution) or--hostname-bin(hostname command execution) flags - Follows the existing pattern of "safe command with dangerous argument exceptions" used by other commands like
find,date,sort, andtree
Comment on lines
+263
to
+267
| // rg (ripgrep) | ||
| // - `--pre`: Executes arbitrary command as preprocessor for every file searched. | ||
| // - `--hostname-bin`: Executes arbitrary command to get hostname. | ||
| rg: true, | ||
| '/^rg\\b.*(--pre|--hostname-bin)\\b/': false, |
There was a problem hiding this comment.
Consider adding test cases for the new rg auto-approval rules to match the pattern used for other commands. The test suite should include:
- Auto-approved case:
'rg pattern file.txt'in theautoApprovedTestCasesarray - Confirmation required cases in the
confirmationRequiredTestCasesarray:'rg --pre cat pattern''rg --hostname-bin hostname pattern'
This would ensure the new rules are properly tested alongside the existing command patterns like find, sort, and tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282824