Skip to content

Conversation

@martin-machacek-tfs
Copy link

Closes #6836

@martin-machacek-tfs martin-machacek-tfs requested a review from a team as a code owner August 18, 2025 07:07
@martin-machacek-tfs
Copy link
Author

@martin-machacek-tfs please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="thermofisher"

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This is a great start!

This is usually the kind of thing we drive across all stable languages to have parity, do you feel like giving a try to other languages?

@martin-machacek-tfs
Copy link
Author

@baywet Just to clarify how to properly set the default value for other languages:

  • Java: explicit getters/setters with private fields?
  • Go: exported struct fields with constructor functions?
  • PHP: private properties with getter/setter methods or constructor promotion?
  • Python: dataclasses with default values or property decorators?

It's a bit out of my scope, but I can try

@martin-machacek-tfs
Copy link
Author

Hi @baywet, I've extended CodePropertyWriter for Java, PHP and Python to generate default values. Default values for Go are already generated via constructor function.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
Thank you for your patience.

Just one minor comment for the changelog and I think we'll be good to go!

@baywet
Copy link
Member

baywet commented Aug 28, 2025

@martin-machacek-tfs it seems some integration tests are failing, would you please mind having a look?
Let us know if you have any additional comments or questions.

@martin-machacek-tfs
Copy link
Author

@martin-machacek-tfs it seems some integration tests are failing, would you please mind having a look? Let us know if you have any additional comments or questions.

@baywet Is there any way to run those integration tests locally? At first glance I have no idea what could be wrong. At least I would expect the existing unit tests to reveal those kind of errors.

@baywet
Copy link
Member

baywet commented Sep 8, 2025

@martin-machacek-tfs yes! If you check the generate code step, it'll tell you which command it used to generate the code

https://github.com/microsoft/kiota/actions/runs/17066554507/job/49093389068#step:16:2

Simply build kiota before handle (dotnet build) and add a -dev argument to that command locally

Once the code is generated, the test step will tell you which command it ran to execute the test.

https://github.com/microsoft/kiota/actions/runs/17066554507/job/49093389068#step:17:8

Let me know if you have any additional comments or questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated RequestBuilderGetQueryParameters class in C# does not include the default value

2 participants