-
Notifications
You must be signed in to change notification settings - Fork 569
Ignore cid-0 #5221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ignore cid-0 #5221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
reviewed
Nov 3, 2025
src/Microsoft.Health.Fhir.Shared.Core/Features/Validation/ProfileValidator.cs
Outdated
Show resolved
Hide resolved
LTA-Thinking
reviewed
Nov 4, 2025
src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Validation/ProfileValidatorTests.cs
Outdated
Show resolved
Hide resolved
LTA-Thinking
reviewed
Nov 4, 2025
src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Validation/ProfileValidatorTests.cs
Outdated
Show resolved
Hide resolved
…es non-existent "name" property
99d3568 to
8ec2829
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LTA-Thinking
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds comprehensive unit tests for the
ProfileValidatorclass and updates its implementation to correctly handle thecid-0constraint based on the FHIR version. The changes improve validation accuracy for different FHIR specifications and ensure that the validator's behavior is thoroughly tested.Unit test coverage for validation logic:
ProfileValidatorTestsinProfileValidatorTests.csto verify that thecid-0constraint is ignored for FHIR R4 and later, but not for STU3, and that the constraint is preserved across validator refreshes.Validation logic improvements:
ProfileValidatorinProfileValidator.csto accept anIModelInfoProviderparameter, enabling version-specific logic for FHIR validation.cid-0to theConstraintsToIgnorelist for FHIR R4 and later, addressing a known spec error.Related issues
Addresses Bug 175473
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)