Skip to content

Conversation

@xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Dec 14, 2025

It turns out that dind badly unstablizes the performance measurement on AMD. We need to disable it when benchmarking.

With dind: https://github.com/meta-pytorch/tritonbench/actions/runs/20238875074/job/58101044583

Screenshot_20251215_032545

Without dind: https://github.com/meta-pytorch/tritonbench/actions/runs/20243373306/job/58116987671?pr=726

Screenshot_20251215_032446

Validate on B200 workflow: https://github.com/pytorch/pytorch-integration-testing/actions/runs/20249046742

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 14, 2025 02:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 14, 2025 02:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 changed the title [amd] disable dind for amd [wip][amd] disable dind for amd Dec 15, 2025
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:34 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 15, 2025 18:35 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 changed the title [wip][amd] disable dind for amd [amd] disable dind for amd Dec 15, 2025
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuzhao9 xuzhao9 merged commit 3c39e60 into main Dec 16, 2025
10 checks passed
@xuzhao9 xuzhao9 deleted the xz9/non-amd-dind branch December 16, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants