Remove nccl_cvars.(h|cc) in favor of genrule-based generation #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Scusemua
pushed a commit
to Scusemua/torchcomms
that referenced
this pull request
Dec 9, 2025
…ytorch#84) Summary: This diff removes the `nccl_cvars.cc` and `nccl_cvars.h` files now that they'll instead be built/generated/provided by `genrule`. This diff also updates several build scripts to be compatible with the new `genrule`-based build for the `ncclx-cvars` library: - MCCL build script, `comms/mccl/build/build.sh` - `comms/ncclx/v2_27/maint/oss_build.sh` - `comms/ncclx/v2_28/maint/oss_build.sh` - `comms/github/build_rcclx.sh` - `comms/github/build_ncclx.sh` - `conda/feedstock/nccl/recipe.yaml` **Note**: this diff was originally published, landed, and reverted as D87668052. Differential Revision: D88748045
Scusemua
force-pushed
the
export-D88748045
branch
from
132aa5f to
5171883
Compare
Scusemua
pushed a commit
to Scusemua/torchcomms
that referenced
this pull request
Dec 9, 2025
…ytorch#84) Summary: This diff removes the `nccl_cvars.cc` and `nccl_cvars.h` files now that they'll instead be built/generated/provided by `genrule`. This diff also updates several build scripts to be compatible with the new `genrule`-based build for the `ncclx-cvars` library: - MCCL build script, `comms/mccl/build/build.sh` - `comms/ncclx/v2_27/maint/oss_build.sh` - `comms/ncclx/v2_28/maint/oss_build.sh` - `comms/github/build_rcclx.sh` - `comms/github/build_ncclx.sh` - `conda/feedstock/nccl/recipe.yaml` **Note**: this diff was originally published, landed, and reverted as D87668052. Differential Revision: D88748045
Scusemua
force-pushed
the
export-D88748045
branch
from
5171883 to
42b91f4
Compare
…ytorch#84) Summary: This diff removes the `nccl_cvars.cc` and `nccl_cvars.h` files now that they'll instead be built/generated/provided by `genrule`. This diff also updates several build scripts to be compatible with the new `genrule`-based build for the `ncclx-cvars` library: - MCCL build script, `comms/mccl/build/build.sh` - `comms/ncclx/v2_27/maint/oss_build.sh` - `comms/ncclx/v2_28/maint/oss_build.sh` - `comms/github/build_rcclx.sh` - `comms/github/build_ncclx.sh` - `conda/feedstock/nccl/recipe.yaml` **Note**: this diff was originally published, landed, and reverted as D87668052. Differential Revision: D88748045
Scusemua
force-pushed
the
export-D88748045
branch
from
42b91f4 to
171df87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff removes the
nccl_cvars.ccandnccl_cvars.hfiles now that they'll instead be built/generated/provided bygenrule.This diff also updates several build scripts to be compatible with the new build methodology for the
ncclx-cvarslibrary.Differential Revision: D88748045