Skip to content

Conversation

@suo
Copy link
Contributor

@suo suo commented Dec 17, 2025

The existing message will hide whether, e.g. there is a symbol mismatch which is super annoying.

…ng full exception tracebacks for better debugging.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 17, 2025
@scotts
Copy link
Contributor

scotts commented Dec 17, 2025

Hi, @suo! The challenge with this approach is that users will hit a giant wall of text where some of the errors are actually expected. That is, if the user has FFmpeg 6 installed, this will show all of the errors when attempting to load the libraries for FFmpeg 4, 5, 6 7 and 8. The user only cares about the errors for FFmpeg 6, but we don't know that; this code is how we figure out which version of FFmpeg will work.

With that said, #1046 proposed basically the same fix. The wall of text is a lot, but folks seem to want the information. The only other way to get this info is to make this hack yourself, so I'm inclined to say let's do this until we get logging in. However, we should also probably update the error message to give some actual guidance on understanding what's going on. @Dan-Flores, @mollyxu, thoughts?

@Dan-Flores
Copy link
Contributor

I agree @scotts, lets merge this PR to enable better debugging.

@mollyxu
Copy link
Contributor

mollyxu commented Dec 17, 2025

Yep I agree @scotts @Dan-Flores! I can work on a follow-up PR that gives users a bit more context on the wall of text

@suo
Copy link
Contributor Author

suo commented Dec 17, 2025

thanks all!

@mollyxu mollyxu merged commit f827b0e into meta-pytorch:main Dec 17, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants