Skip to content

[MLIR][MemRef] Emit error on atomic generic result op defined outside the region #172190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashermancinelli merged 1 commit into from
Dec 14, 2025
+18 −1
Merged

[MLIR][MemRef] Emit error on atomic generic result op defined outside the region #172190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,12 @@ struct GenericAtomicRMWOpLowering
Operation *clone = rewriter.clone(nestedOp, mapping);
mapping.map(nestedOp.getResults(), clone->getResults());
}
Value result = mapping.lookup(entryBlock.getTerminator()->getOperand(0));

Value result =
mapping.lookupOrNull(entryBlock.getTerminator()->getOperand(0));
if (!result) {
return atomicOp.emitError("result not defined in region");
}

// Prepare the epilog of the loop block.
// Append the cmpxchg op to the end of the loop block.
Expand Down
12 changes: 12 additions & 0 deletions mlir/test/Conversion/MemRefToLLVM/invalid.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,15 @@ func.func @issue_70160() {
memref.store %0, %alloc1[] : memref<i32>
func.return
}


// -----

func.func @test_atomic_exch(%arg0: memref<?xi32>, %idx: index, %value: i32) {
// expected-error @+1 {{result not defined in region}}
%1 = memref.generic_atomic_rmw %arg0[%idx] : memref<?xi32> {
^bb0(%arg3: i32):
memref.atomic_yield %value : i32
}
func.return
}