Skip to content

[CIR] Rename allEnumCasesCovered to all_enum_cases_covered #172153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xlauko wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

[CIR] Rename allEnumCasesCovered to all_enum_cases_covered #172153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/include/clang/CIR/Dialect/IR/CIROps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,7 @@ def CIR_SwitchOp : CIR_Op<"switch", [

let arguments = (ins
CIR_IntType:$condition,
UnitAttr:$allEnumCasesCovered
UnitAttr:$all_enum_cases_covered
);

let regions = (region AnyRegion:$body);
Expand All @@ -1229,7 +1229,7 @@ def CIR_SwitchOp : CIR_Op<"switch", [

let assemblyFormat = [{
`(` $condition `:` qualified(type($condition)) `)`
(`allEnumCasesCovered` $allEnumCasesCovered^)?
(`all_enum_cases_covered` $all_enum_cases_covered^)?
$body
attr-dict
}];
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CIR/CodeGen/switch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@ void testSwitchCoverAllCase(M m) {
break;
}
}
// CIR: cir.switch(%[[ARG:.*]] : !s32i) allEnumCasesCovered {
// CIR: cir.switch(%[[ARG:.*]] : !s32i) all_enum_cases_covered {

void testSwitchNotCoverAllCase(M m) {
switch (m) {
Expand Down
4 changes: 2 additions & 2 deletions clang/test/CIR/IR/switch.cir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ cir.func @s0() {

// Pretends that this is lowered from a C file and was tagged with allEnumCasesCovered = true
cir.func @s1(%1 : !s32i) {
cir.switch (%1 : !s32i) allEnumCasesCovered {
cir.switch (%1 : !s32i) all_enum_cases_covered {
cir.case (default, []) {
cir.return
}
Expand All @@ -54,7 +54,7 @@ cir.func @s1(%1 : !s32i) {
} { }
cir.return
}
// CHECK: cir.switch(%[[ARG:.*]] : !s32i) allEnumCasesCovered {
// CHECK: cir.switch(%[[ARG:.*]] : !s32i) all_enum_cases_covered {
// CHECK-NEXT: cir.case(default, []) {
// CHECK-NEXT: cir.return
// CHECK-NEXT: }
Expand Down