release/21.x: [llvm-offload-wrapper] Fix Triple and OpenMP handling (#167580) #172151
Conversation
Summary: The OpenMP handling using an offload binary should be optional, it's only used for extra metadata for llvm-objdump. Also the triple was completely wrong, it didn't let anyone correctly choose between ELF and COFF handling. (cherry picked from commit 6655681)
|
cc @ZuseZ4 |
|
Is this a regression from a previous release? If so, which one? This is going to be the final release from the LLVM 21.x branch, so any issues from taking this change would not be fixed until LLVM 22 releases in about a month. And considering this is the final release of 21.x, we need to be very careful what changes are included. What would be the impact of not accepting this change for 21 and waiting for 22 instead? |
Honestly, it's more of a feature. It makes the utility more usable but it's not strictly required nor does it fix a bug. This, I believe, comes from the Rust team wanting to more easily use this utility. We usually don't backport features so it's up to you. |
3 participants
Backport 6655681.