Skip to content

Conversation

@bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Dec 11, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Added unit tests for extended resource handling in kubelet lifecycle predicates
and scheduler admission checks:

  • kubelet lifecycle: Test that extended resources with zero Allocatable are
    not removed, and resources missing from node Allocatable are filtered from
    pod requests

  • scheduler admission: Test that missing extended resources cause admission
    failures by default, and are allowed when DRAExtendedResource feature gate
    is enabled (for Dynamic Resource Allocation scenarios)

Which issue(s) this PR is related to:

#135669

Special notes for your reviewer:

I added these test cases while investigating #135669 and found them useful enough to justify creating a PR.

Does this PR introduce a user-facing change?

NONE

/sig node
/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested a review from yliaog December 11, 2025 19:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.35 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.35.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 11 15:40:23 UTC 2025.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 11, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 11, 2025
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node: code and documentation PRs Dec 11, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Dec 11, 2025
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

@bart0sh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dra-integration 99b3cdd link false /test pull-kubernetes-dra-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bart0sh bart0sh force-pushed the PR211-add-extended-resources-test-cases branch from 99b3cdd to 7306817 Compare December 12, 2025 08:27
Add unit test cases for extended resource handling in kubelet lifecycle
predicates and scheduler admission checks:

- kubelet lifecycle: Test that extended resources with zero Allocatable are
  not removed, and resources missing from node Allocatable are filtered from
  pod requests

- scheduler admission: Test that missing extended resources cause admission
  failures by default, and are allowed when DRAExtendedResource feature gate
  is enabled (for Dynamic Resource Allocation scenarios)
@bart0sh bart0sh force-pushed the PR211-add-extended-resources-test-cases branch from 7306817 to 670a488 Compare December 12, 2025 08:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bart0sh
Once this PR has been reviewed and has the lgtm label, please assign kerthcet, tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 12, 2025

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly December 12, 2025 11:32
),
},
{
desc: "requests for extended resources that are not available in node should be removed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the same as the test at line 81: "requests for resources unavailable in node should be removed" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 🆕 New
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants