-
Notifications
You must be signed in to change notification settings - Fork 41.9k
Add new extended resources test cases #135725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new extended resources test cases #135725
Conversation
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 11 15:40:23 UTC 2025. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bart0sh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
99b3cdd to
7306817
Compare
Add unit test cases for extended resource handling in kubelet lifecycle predicates and scheduler admission checks: - kubelet lifecycle: Test that extended resources with zero Allocatable are not removed, and resources missing from node Allocatable are filtered from pod requests - scheduler admission: Test that missing extended resources cause admission failures by default, and are allowed when DRAExtendedResource feature gate is enabled (for Dynamic Resource Allocation scenarios)
7306817 to
670a488
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bart0sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @pohly |
| ), | ||
| }, | ||
| { | ||
| desc: "requests for extended resources that are not available in node should be removed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the same as the test at line 81: "requests for resources unavailable in node should be removed" ?
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Added unit tests for extended resource handling in kubelet lifecycle predicates
and scheduler admission checks:
kubelet lifecycle: Test that extended resources with zero Allocatable are
not removed, and resources missing from node Allocatable are filtered from
pod requests
scheduler admission: Test that missing extended resources cause admission
failures by default, and are allowed when DRAExtendedResource feature gate
is enabled (for Dynamic Resource Allocation scenarios)
Which issue(s) this PR is related to:
#135669
Special notes for your reviewer:
I added these test cases while investigating #135669 and found them useful enough to justify creating a PR.
Does this PR introduce a user-facing change?
/sig node
/cc @yliaog