setup registry - k8s-staging-node-readiness-controller #8832

Priyankasaggu11929 · 2025-12-03T13:08:52Z

Required for hosting images for https://github.com/kubernetes-sigs/node-readiness-controller repo

cc: @ajaysundark

Priyankasaggu11929 · 2025-12-03T14:09:40Z

/test pull-k8sio-cip

ajaysundark · 2025-12-03T18:18:46Z

/lgtm
/approve

Thanks for setting this up @Priyankasaggu11929!

ajaysundark · 2025-12-03T18:21:19Z

/cc @BenTheElder @ameukam for k8s-infra

k8s-ci-robot · 2025-12-03T18:21:24Z

@ajaysundark: GitHub didn't allow me to request PR reviews from the following users: for, k8s-infra.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BenTheElder @ameukam for k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BenTheElder · 2025-12-03T18:34:29Z

/cc @BenTheElder @ameukam for k8s-infra

I'm not a K8s Infra TL anymore and I can't /approve:

k8s.io/OWNERS

Lines 6 to 8 in 87b2549

    
           emeritus_approvers: 
        
           - bartsmykla 
        
           - BenTheElder

BenTheElder · 2025-12-03T18:34:44Z

/uncc

Priyankasaggu11929 · 2025-12-04T08:53:41Z

@Priyankasaggu11929 Sorry it's not properly documented but the distribution group is a requirement to set up the staging repo. So you want to split this PR.

Thank you @ameukam.

Let me send a PR splitting the distribution creation.

Priyankasaggu11929 · 2025-12-04T09:02:59Z

Let me send a PR splitting the distribution creation.

addressed in https://github.com/kubernetes/k8s.io/pull/8838/files

Priyankasaggu11929 · 2025-12-04T10:35:22Z

/test pull-k8sio-cip

registry.k8s.io/manifests/k8s-staging-node-readiness-controller/promoter-manifest.yaml

registry.k8s.io/images/k8s-staging-node-readiness-controller/OWNERS

ameukam · 2025-12-04T10:46:29Z

registry.k8s.io/manifests/k8s-staging-node-readiness-controller/promoter-manifest.yaml

@@ -0,0 +1,49 @@
+# google group for gcr.io/k8s-staging-node-readiness-controller is [email protected]
+registries:
+  - name: gcr.io/k8s-staging-node-readiness-controller


Suggested change

- name: gcr.io/k8s-staging-node-readiness-controller

- name: us-central1-docker.pkg.dev/k8s-staging-images/node-readiness-controller

Addressed all review comments in latest commit refresh. Thanks for pointing, @ameukam. 🙏

Just for my understanding - what is the difference between using the above 2 registries? when to use which one?

(Thanks again in advance!)

These are different products in Google Cloud (which seems to be hosting k8s bits too).
gcr is deprecated, and the pkg.dev repositories are from Artifact Registry. fyi, https://docs.cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

ameukam · 2025-12-05T08:49:14Z

atlantis plan

ameukam · 2025-12-05T08:54:53Z

@upodroid Looks like a service identity for AR will be added to all the AR repos. Is it expected ?

Priyankasaggu11929 · 2025-12-09T11:35:29Z

@upodroid Looks like a service identity for AR will be added to all the AR repos. Is it expected ?

@upodroid - pinging for your input on above ^. Thank you!

upodroid · 2025-12-09T13:50:05Z

Sorry for the delay, I'll look into it today

Priyankasaggu11929 · 2025-12-09T14:01:48Z

Sorry for the delay, I'll look into it today

Thank you 🙏

Priyankasaggu11929 · 2025-12-15T08:07:55Z

Hello @upodroid, just another ping for your review. Thanks!

upodroid · 2025-12-15T12:56:30Z

atlantis plan

k8s-infra-ci-robot · 2025-12-15T12:56:54Z

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Show Output

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.artifact_registry["agent-sandbox"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/agent-sandbox"
        name                   = "agent-sandbox"
      ~ update_time            = "2025-11-25T17:13:20.737743Z" -> "2025-12-10T14:31:55.340386Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
        name                   = "cloud-provider-kind"
      ~ update_time            = "2025-11-25T10:49:07.105086Z" -> "2025-12-15T02:36:02.141277Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["contributor-site"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/contributor-site"
        name                   = "contributor-site"
      ~ update_time            = "2025-11-19T17:27:23.971093Z" -> "2025-12-05T17:19:28.079265Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["csi-vsphere"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/csi-vsphere"
        name                   = "csi-vsphere"
      ~ update_time            = "2025-11-25T15:41:31.178744Z" -> "2025-12-15T08:50:11.695662Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["dra-example-driver"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/dra-example-driver"
        name                   = "dra-example-driver"
      ~ update_time            = "2025-10-30T07:32:59.319403Z" -> "2025-12-10T20:49:35.204243Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["etcd-manager"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/etcd-manager"
        name                   = "etcd-manager"
      ~ update_time            = "2025-11-01T19:51:41.499498Z" -> "2025-12-14T18:33:53.461829Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension"
        name                   = "gateway-api-inference-extension"
      ~ update_time            = "2025-11-25T17:23:18.944644Z" -> "2025-12-15T08:49:18.657149Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/infra-tools"
        name                   = "infra-tools"
      ~ update_time            = "2025-10-31T11:44:11.648754Z" -> "2025-12-13T20:25:32.076123Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/ingress-nginx"
        name                   = "ingress-nginx"
      ~ update_time            = "2025-11-25T10:48:15.203365Z" -> "2025-12-14T20:09:43.665422Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["jobset"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/jobset"
        name                   = "jobset"
      ~ update_time            = "2025-11-25T02:31:32.437238Z" -> "2025-12-15T02:35:47.570218Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kro"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kro"
        name                   = "kro"
      ~ update_time            = "2025-11-25T08:53:28.664873Z" -> "2025-12-13T01:59:13.179198Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
        name                   = "kueue"
      ~ update_time            = "2025-11-25T16:52:50.949330Z" -> "2025-12-15T12:07:52.944449Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["lws"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/lws"
        name                   = "lws"
      ~ update_time            = "2025-11-25T09:03:33.956982Z" -> "2025-12-14T21:04:57.421458Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["minikube"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/minikube"
        name                   = "minikube"
      ~ update_time            = "2025-08-28T19:30:36.700112Z" -> "2025-12-14T21:22:48.686913Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place

Terraform will perform the following actions:

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
      + cleanup_policy_dry_run = false
      + create_time            = (known after apply)
      + effective_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + format                 = "DOCKER"
      + id                     = (known after apply)
      + location               = "us-central1"
      + mode                   = "STANDARD_REPOSITORY"
      + name                   = (known after apply)
      + project                = "k8s-staging-images"
      + repository_id          = "node-readiness-controller"
      + terraform_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + update_time            = (known after apply)

      + cleanup_policies {
          + action = "DELETE"
          + id     = "delete-images-older-than-90-days"

          + condition {
              + older_than            = "7776000s"
              + package_name_prefixes = []
              + tag_prefixes          = []
              + tag_state             = "ANY"
              + version_name_prefixes = []
                # (1 unchanged attribute hidden)
            }
        }
    }

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "allUsers"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.reader"
    }

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "group:[email protected]"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.writer"
    }

  # module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
        id      = "k8s-staging-images/roles/viewer"
      ~ members = [
          + "group:[email protected]",
            # (28 unchanged elements hidden)
        ]
        # (3 unchanged attributes hidden)
    }

Plan: 3 to add, 1 to change, 0 to destroy.

▶️ To apply this plan, comment:

atlantis apply -d infra/gcp/terraform/k8s-staging-images

🚮 To delete this plan and lock, click here

🔁 To plan this project again, comment:

atlantis plan -d infra/gcp/terraform/k8s-staging-images

Note: Objects have changed outside of Terraform
Plan: 3 to add, 1 to change, 0 to destroy.
🔀 Upstream was modified, a new merge was performed.

⏩ To apply all unapplied plans from this Pull Request, comment:
```
atlantis apply
```
🚮 To delete all plans and locks from this Pull Request, comment:
```
atlantis unlock
```

upodroid · 2025-12-15T12:57:28Z

A bug was introduced in the terraform module. (We grab the latest minor release of the module). It was reverted

GoogleCloudPlatform/terraform-google-artifact-registry#84

upodroid · 2025-12-15T12:57:42Z

atlantis apply

k8s-infra-ci-robot · 2025-12-15T12:58:08Z

Ran Apply for dir: infra/gcp/terraform/k8s-staging-images workspace: default

module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository.repo: Creating...
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifying... [id=k8s-staging-images/roles/viewer]
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifications complete after 7s [id=k8s-staging-images/roles/viewer]
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository.repo: Still creating... [10s elapsed]
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository.repo: Creation complete after 11s [id=projects/k8s-staging-images/locations/us-central1/repositories/node-readiness-controller]
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"]: Creating...
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creating...
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"]: Creation complete after 7s [id=projects/k8s-staging-images/locations/us-central1/repositories/node-readiness-controller/roles/artifactregistry.writer/group:[email protected]]
module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creation complete after 7s [id=projects/k8s-staging-images/locations/us-central1/repositories/node-readiness-controller/roles/artifactregistry.reader/allUsers]

Apply complete! Resources: 3 added, 1 changed, 0 destroyed.

k8s-ci-robot · 2025-12-15T12:58:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, Priyankasaggu11929, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Priyankasaggu11929 · 2025-12-15T13:42:57Z

Thank you for your help, @upodroid @ameukam 🙏

k8s-ci-robot · 2025-12-15T14:08:24Z

@Priyankasaggu11929: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-k8sio-cip	`3e1df4b`	link	unknown	`/test pull-k8sio-cip`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot requested a review from derekwaynecarr December 3, 2025 13:09

k8s-ci-robot added the area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ label Dec 3, 2025

k8s-ci-robot requested a review from GenPage December 3, 2025 13:09

k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2025

Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch 2 times, most recently from 81a2105 to f565e3d Compare December 3, 2025 13:47

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2025

Priyankasaggu11929 mentioned this pull request Dec 3, 2025

[Tracking] setup staging registry for the project kubernetes-sigs/node-readiness-controller#20

Open

Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch from f565e3d to 4d50bf9 Compare December 3, 2025 14:25

k8s-ci-robot assigned ajaysundark Dec 3, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025

k8s-ci-robot requested review from BenTheElder and ameukam December 3, 2025 18:21

k8s-ci-robot removed the request for review from BenTheElder December 3, 2025 18:34

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025

Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch from f25719e to 36a650e Compare December 4, 2025 09:01

Priyankasaggu11929 mentioned this pull request Dec 4, 2025

create new staging dl for node-readiness-controller #8838

Merged

ameukam reviewed Dec 4, 2025

View reviewed changes

registry.k8s.io/manifests/k8s-staging-node-readiness-controller/promoter-manifest.yaml Outdated Show resolved Hide resolved

ameukam reviewed Dec 4, 2025

View reviewed changes

registry.k8s.io/images/k8s-staging-node-readiness-controller/OWNERS Outdated Show resolved Hide resolved

ameukam reviewed Dec 4, 2025

View reviewed changes

setup registry - k8s-staging-node-readiness-controller

3e1df4b

Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch from 36a650e to 3e1df4b Compare December 4, 2025 11:35

This comment has been minimized.

Sign in to view

upodroid approved these changes Dec 15, 2025

View reviewed changes

k8s-ci-robot assigned upodroid Dec 15, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2025

	- name: gcr.io/k8s-staging-node-readiness-controller
	- name: us-central1-docker.pkg.dev/k8s-staging-images/node-readiness-controller

setup registry - k8s-staging-node-readiness-controller #8832

Are you sure you want to change the base?

setup registry - k8s-staging-node-readiness-controller #8832

Conversation

Priyankasaggu11929 commented Dec 3, 2025

Uh oh!

Priyankasaggu11929 commented Dec 3, 2025

Uh oh!

ajaysundark commented Dec 3, 2025

Uh oh!

ajaysundark commented Dec 3, 2025

Uh oh!

k8s-ci-robot commented Dec 3, 2025

Uh oh!

BenTheElder commented Dec 3, 2025

Uh oh!

BenTheElder commented Dec 3, 2025

Uh oh!

Priyankasaggu11929 commented Dec 4, 2025

Uh oh!

Priyankasaggu11929 commented Dec 4, 2025

Uh oh!

Priyankasaggu11929 commented Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

ameukam Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

ajaysundark Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

ameukam commented Dec 5, 2025

Uh oh!

This comment has been minimized.

ameukam commented Dec 5, 2025

Uh oh!

Priyankasaggu11929 commented Dec 9, 2025

Uh oh!

upodroid commented Dec 9, 2025

Uh oh!

Priyankasaggu11929 commented Dec 9, 2025

Uh oh!

Priyankasaggu11929 commented Dec 15, 2025

Uh oh!

upodroid commented Dec 15, 2025

Uh oh!

k8s-infra-ci-robot commented Dec 15, 2025

Uh oh!

upodroid commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

upodroid commented Dec 15, 2025

Uh oh!

k8s-infra-ci-robot commented Dec 15, 2025

Uh oh!

k8s-ci-robot commented Dec 15, 2025

Uh oh!

Priyankasaggu11929 commented Dec 15, 2025

Uh oh!

k8s-ci-robot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

upodroid commented Dec 15, 2025 •

edited

Loading