Skip to content

Conversation

@ShaneK
Copy link
Member

@ShaneK ShaneK commented Dec 11, 2025

resolves #4355

Fixes React tabs router examples to include IonPage wrapper around page content.

  • Wrap tab page components in IonPage to provide proper flex layout
  • Fixes issue where IonContent overlaps IonTabBar when placed in bottom slot
  • Updates examples for v6, v7, and v8

Problem

The React tabs router examples were missing the IonPage wrapper, causing IonContent to extend over the IonTabBar.

Solution

Each routed tab page component needs to be wrapped in IonPage:

// Before (broken)
const HomePage = () => (
  <>
    <IonHeader>...</IonHeader>
    <IonContent>...</IonContent>
  </>
);
// After (fixed)
const HomePage = () => (
  <IonPage>
    <IonHeader>...</IonHeader>
    <IonContent>...</IonContent>
  </IonPage>
);

@ShaneK ShaneK requested a review from a team as a code owner December 11, 2025 22:30
@ShaneK ShaneK requested a review from brandyscarney December 11, 2025 22:30
@vercel
Copy link

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ionic-docs Ready Ready Preview, Comment Dec 16, 2025 5:15pm

@ShaneK ShaneK requested a review from thetaPC December 11, 2025 22:30
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also mention within each frameworks' IonPage page that it's needed for styling as well?

@ShaneK
Copy link
Member Author

ShaneK commented Dec 16, 2025

LGTM, can we also mention within each frameworks' IonPage page that it's needed for styling as well?

How about this?

CleanShot 2025-12-16 at 09 11 22

Commit 6289d53

Direct preview link

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneK ShaneK merged commit 6c33611 into main Dec 16, 2025
4 checks passed
@ShaneK ShaneK deleted the FW-6390 branch December 16, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-content goes over ion-tab-bar when setup with router

4 participants