fix: skip packages without SBOM during vulnerability scanning #313
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
force-pushed
the
ldd/skip-missing-sbom
branch
from
17fa045 to
e1780b1
Compare
When vulnerability scanning runs on packages downloaded from remote cache that were built with older Leeway versions (before SBOM support), skip gracefully with a warning instead of failing the build. Only locally built packages (PackageBuilt) fail if SBOM is missing, since we just generated it and missing SBOM indicates a bug. Downloaded packages (PackageDownloaded) skip with a warning since older cache artifacts may not have SBOM files. Co-authored-by: Ona <[email protected]>
leodido
force-pushed
the
ldd/skip-missing-sbom
branch
from
e1780b1 to
b5e3cbf
Compare
corneliusludmann
approved these changes
Dec 12, 2025
leodido
force-pushed
the
ldd/skip-missing-sbom
branch
from
362e536 to
b5e3cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip SBOM vulnerability scan for downloaded packages that don't have SBOM files, instead of failing the build.
Part of https://linear.app/ona-team/issue/CLC-2133/rollout-on-main
Problem
When vulnerability scanning is enabled (
sbom.scanVulnerabilities: true), packages downloaded from remote cache that were built with older Leeway versions (before SBOM support) cause the build to fail:Solution
Differentiate between downloaded and locally built packages:
PackageDownloadedPackageBuiltThis ensures:
Testing
Related