Skip to content

Conversation

@michaelnebel
Copy link
Contributor

In this PR we migrate our own solution file to .slnx. After the migration it becomes evident that we forgot to exclude some of the test projects from the release configuration. As we use bazel for building the extractor, I don't think it means anything in practice - adding the test project exclusions for consistency.

@github-actions github-actions bot added the C# label Dec 12, 2025
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Dec 12, 2025
@michaelnebel michaelnebel marked this pull request as ready for review December 12, 2025 13:50
@michaelnebel michaelnebel requested a review from a team as a code owner December 12, 2025 13:50
Copilot AI review requested due to automatic review settings December 12, 2025 13:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the C# solution file from the traditional .sln format to the newer .slnx format (XML-based). The migration ensures all 15 projects are properly included and corrects a configuration oversight where two test projects were previously included in Release builds.

Key changes:

  • Replaced CSharp.sln with CSharp.slnx using XML format
  • Excluded all four test projects from Release configuration (previously only 2 were excluded)
  • Updated VS Code settings to reference the new .slnx file

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
csharp/CSharp.slnx New XML-based solution file with all 15 projects and proper Release build exclusions for test projects
csharp/CSharp.sln Removed legacy solution file
csharp/.vscode/settings.json Updated default solution reference from CSharp.sln to CSharp.slnx

The migration appears to be complete and correct. All projects from the original solution are present in the new .slnx file, and the test project exclusions for Release builds are now consistent across all test projects. The VS Code settings have been appropriately updated to reference the new solution file.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant