Skip to content

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This pull request introduces a centralized configuration for System-on-Chip (SoC) targets in CI scripts, refactoring the way SoC lists and properties are managed across the project. The main improvement is the introduction of a new socs_config.sh file, which defines all supported SoCs, their properties, and helper functions. All relevant CI scripts are updated to source this configuration, reducing duplication and making it easier to add or update SoC support. Several scripts are also refactored to use these centralized lists and helper functions, and logic is added to handle default behaviors for building and running tests across multiple targets.

Centralization of SoC Configuration:

  • Added .github/scripts/socs_config.sh containing all SoC lists, target groups, IDF version mappings, helper functions for property lookup, and computed arrays for build/test targets. This file is now sourced by all major CI scripts to provide a single source of truth for SoC support.

Refactoring CI Scripts to Use Centralized Config:

  • Updated find_all_boards.sh, on-push.sh, tests_build.sh, tests_matrix.sh, and tests_run.sh to source socs_config.sh and use its arrays and helper functions instead of hardcoded SoC lists. [1] [2] [3] [4] [5]

Build and Test Logic Improvements:

  • Refactored build and test scripts (on-push.sh, tests_build.sh, tests_run.sh) to loop over the centralized BUILD_TEST_TARGETS array instead of hardcoded targets, and to handle default behaviors when no target or sketch is specified, enabling builds/runs for all targets or all sketches as appropriate. [1] [2] [3] [4] [5]

QEMU and Architecture Handling:

  • Updated tests_run.sh to use helper functions from socs_config.sh for QEMU support and architecture detection, improving maintainability and ensuring only supported targets are run in QEMU.

New Script for Official Variant Change Detection:

  • Added check_official_variants.sh, a script to determine if CI workflows should run based on whether official variants were changed, using the centralized SoC lists for accurate detection.

Test Scenarios

Locally and GitLab CI.

@lucasssvaz lucasssvaz self-assigned this Dec 16, 2025
@lucasssvaz lucasssvaz added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. CI Failure Expected For PRs where CI failure is expected labels Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Apply suggestions from code review":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 This PR seems to be quite large (total lines of code: 2203), you might consider splitting it into smaller PRs

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8b8b3fe

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Test Results

 90 files   90 suites   27m 28s ⏱️
 66 tests  56 ✅ 0 💤 10 ❌
670 runs  650 ✅ 0 💤 20 ❌

For more details on these failures, see this check.

Results for commit 8b8b3fe.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C5000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Server000000000000----
libraries/ESP32/examples/Camera/CameraWebServer00----------00--
ESP32/examples/Camera/CameraWebServer (2)00----------00--
libraries/Insights/examples/MinimalDiagnostics00000000----00--
libraries/NetworkClientSecure/examples/WiFiClientSecure00000000--0000--
ESP32/examples/Camera/CameraWebServer (3)----------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Failure Expected For PRs where CI failure is expected Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants