-
Notifications
You must be signed in to change notification settings - Fork 187
[Infra and hosts] Add info on supported data sources for Infra Inventory #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra and hosts] Add info on supported data sources for Infra Inventory #4306
Conversation
Vale Linting ResultsSummary: 6 suggestions found 💡 Suggestions (6)
|
|
Thanks @mdbirnstiehl - looking good! Could we make some tweaks? 1. Update Metrics Reference docs to make I know it's at the bottom but I think we should remove this section and make it super clear as part of each entity type. I think it might actually be quite easy to update it as follows to solve a lot of problems at once:
1. Updated text
2. Refer to the identifier 3. No changes here except for putting it in a title 4. Nice tweak to reflect the sections 2. Ensure other entity types in Infra Inventory docs point towards the relevant metrics references To make sure users don't miss the required metric references per entity type, could you update the 'view host metrics', 'view container metrics' and 'view metrics from other resources' to point towards the relevant metrics references too? |
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions for your consideration, hope they're helpful. If you like some of them, like the rewrite suggestions for the NOTE, they could apply in a few other places throughout the PR.

This PR closes #4077 and #4076 and updates the Infrastructure UI and metrics reference docs to show that only data from supported integrations can be used in the Infrastructure UI.