Skip to content

Conversation

@Jand42
Copy link

@Jand42 Jand42 commented Dec 12, 2025

Adding a new optional parameter keepAssemblyContents to FsiEvaluationSession.ParseAndCheckInteraction.

This is a minor change that enables using an fsi session and also doing full content analysis on entered interactions. I have used a local build of my changes to make a WebSharper-enabled interactive session.

Question: would an overload be preferred instead of optional argument to keep binary compatibility? Or it's not a primary concern for FCS and code compatibility is enough?

@Jand42
Copy link
Author

Jand42 commented Dec 12, 2025

@dotnet-policy-service agree company="IntelliFactory"

@vzarytovskii
Copy link
Member

This would be binary breaking. Which is not bad by default, just so it's a concious decision.

@Jand42
Copy link
Author

Jand42 commented Dec 15, 2025

@vzarytovskii I'm happy to make it non-breaking with an overload or differently named method (ParseAndCheckInteractionAndKeepAssemblyContents would be descriptive, but pretty long...). Please advise, thank you!

@vzarytovskii
Copy link
Member

@vzarytovskii I'm happy to make it non-breaking with an overload or differently named method (ParseAndCheckInteractionAndKeepAssemblyContents would be descriptive, but pretty long...). Please advise, thank you!

Overload is usually good enough, but it's up to @T-Gro, if breaking change is fine or not.

@github-actions
Copy link
Contributor

❗ Release notes required

@Jand42,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.200.md No release notes found or release notes format is not correct

@T-Gro
Copy link
Member

T-Gro commented Dec 15, 2025

A sibling PR is removing switches for ML compat syntax anyway, so the upcoming FCS api will not be backwards compatible with the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

3 participants