-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update file-based apps reference article #50604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DamianEdwards
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the file-based .NET apps reference documentation based on review feedback. The changes improve CLI command documentation, clarify build and caching behavior, and refine advanced features like publishing and user secrets management.
Key changes:
- Enhanced CLI command examples with explicit
--fileoption usage and argument passing conventions - Updated NuGet package reference syntax from
version="x.x.x"to@x.x.xformat - Clarified build caching behavior and provided explicit cache cleanup instructions
DamianEdwards
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Summary
Address comments from review feedback in: #50371
This pull request updates the documentation for file-based .NET apps, focusing on clarifying CLI usage, improving explanations of build and caching behavior, and providing more precise instructions for advanced scenarios. The changes aim to make the documentation more accurate and user-friendly by refining command syntax, clarifying default behaviors, and adding details on cache management and publishing.
CLI Command Usage and Syntax Improvements:
dotnet run, emphasizing the use of the--fileoption and providing updated examples for passing arguments, including the recommended use of--to separate app arguments.--daysfor cache cleanup and clarified the difference between deleting artifacts for a single file and a directory.NuGet and SDK Reference Syntax:
#:package Serilog version="3.1.1"to#:package [email protected]for consistency, and added an example for referencing a specific SDK version.User Secrets and Advanced Features:
--fileoption instead of--project, and added an example for listing secrets.Build Output and Caching Behavior:
Internal previews