Skip to content

Conversation

@sgrekhov
Copy link

Some comments to this PR.

  • The updated test test_removesSpaceAfterTripleSlashes is failing. But the specification clearly states that

For each line that begins with ///, the parser removes the three slashes and all leading whitespace to produce the documentation text

So, I believe it is a bug in the current implementation. It should be fixed to follow the spec.

  • test_whitespacesInCodeSpan also fails. The spec says that whitespaces inside fenced code blocks should be preserved. But in this test we have a code span (`). Spec says that fenced code blocks are the only exception in all other cases all leading whitespaces should be removed. Therefore it is an implementation issue again.
  • The spec says "Exception: inside fenced code blocks (```)...". Github flavored markdown also supports ~~~ as begin/end of code blocks. Probably it makes sense to mention it to the spec. Say "Exception: inside fenced code blocks (``` or ~~~)...".

cc @srawlins because the change affects his comment.

@sgrekhov
Copy link
Author

@szakarias @athomas please grant me the permission to assign reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant