-
Notifications
You must be signed in to change notification settings - Fork 451
Add docs for sw.os and sw.kernel container contract labels
#3259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dcc8ee2 to
8d127b8
Compare
|
Website deployed to CF Pages, 👀 preview link https://dcc1d712.balenacloud-docs.pages.dev |
8d127b8 to
0049dab
Compare
0049dab to
1d45988
Compare
pipex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments
| io.balena.features.requires.arch.sw: 'aarch64' | ||
| ``` | ||
|
|
||
| {{ $names.company.upper }} also supports specifying OS and kernel slug and version requirements. Multiple OS or kernel slugs may be specified at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit misleading, we don't support multiple OSs (yet)
| {{ $names.company.upper }} also supports specifying OS and kernel slug and version requirements. Multiple OS or kernel slugs may be specified at a time. | |
| {{ $names.company.upper }} also supports specifying version requirements for the Linux kernel and balenaOS. |
| ``` | ||
|
|
||
| {{ $names.company.upper }} also supports specifying OS and kernel slug and version requirements. Multiple OS or kernel slugs may be specified at a time. | ||
| | Label | Type | Description | Valid from Supervisor | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create a different table? I would add these requirements to the table above and maybe add a separate paragraph and example
Also, this has a Type column which is not really necessary as the use of contracts is an implementation detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combined table into existing table, I've also removed all mentions of "multiple OS" and references to the sw.os contract type.
Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
1d45988 to
c80e4fb
Compare
Relates-to: balena-io-modules/balena-compose#117
Relates-to: balena-os/balena-supervisor#2444
Change-type: patch