-
Notifications
You must be signed in to change notification settings - Fork 25
Add ownership verification for EKS/ECS MCPs for registry #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| LLMs are non-deterministic and they make mistakes, we advise you to always thoroughly test and follow the best practices of your organization before using these tools on customer facing accounts. Users of this package are solely responsible for implementing proper security controls and MUST use AWS Identity and Access Management (IAM) to manage access to AWS resources. You are responsible for configuring appropriate IAM policies, roles, and permissions, and any security vulnerabilities resulting from improper IAM configuration are your sole responsibility. By using this package, you acknowledge that you have read and understood this disclaimer and agree to use the package at your own risk. | ||
|
|
||
| <!-- mcp-name: io.github.awslabs/eks-mcp-server --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should awslabs or aws be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it just has to match the name exactly from the server.json, proposed change
Now I think the org there is just related to the owner of the publisher. But I think it should match the value from repository since the Pypi package (ie. mcp-proxy-for-aws) doesn't map to the GitHub in the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, as long as you are certain about this change, we can give it a go and try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear if the io.github.awslabs is the most appropriate or not. Is it a one-way door?
|
|
||
| LLMs are non-deterministic and they make mistakes, we advise you to always thoroughly test and follow the best practices of your organization before using these tools on customer facing accounts. Users of this package are solely responsible for implementing proper security controls and MUST use AWS Identity and Access Management (IAM) to manage access to AWS resources. You are responsible for configuring appropriate IAM policies, roles, and permissions, and any security vulnerabilities resulting from improper IAM configuration are your sole responsibility. By using this package, you acknowledge that you have read and understood this disclaimer and agree to use the package at your own risk. | ||
|
|
||
| <!-- mcp-name: io.github.awslabs/eks-mcp-server --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, as long as you are certain about this change, we can give it a go and try.
Signed-off-by: wzxxing <[email protected]>
add new line at the end of the file Signed-off-by: wzxxing <[email protected]>
Summary
Changes
Add verification strings for AWS EKS and AWS ECS MCP servers for the Official MCP Registry. See their documentation for context
User experience
No change. Metadata changes only.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
Please add details about how this change was tested.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.