Skip to content

add cancellation #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GarrettBeatty wants to merge 1 commit into from
Closed

add cancellation #4221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion sdk/src/Services/S3/Custom/Transfer/Internal/MultipartDownloadManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,23 @@ public async Task StartDownloadsAsync(DownloadDiscoveryResult discoveryResult, E
catch (Exception ex)
{
_downloadException = ex;
_logger.Error(ex, "MultipartDownloadManager: Background download task failed");



// Cancel all remaining downloads immediately to prevent cascading timeout errors
// This ensures that when one part fails, other tasks stop gracefully instead of
// continuing until they hit their own timeout/cancellation errors
try
{
internalCts.Cancel();
_logger.DebugFormat("MultipartDownloadManager: Cancelled all in-flight downloads due to error");
}
catch (ObjectDisposedException)
{
// CancellationTokenSource was already disposed, ignore
_logger.DebugFormat("MultipartDownloadManager: CancellationTokenSource already disposed during cancellation");
}

_dataHandler.OnDownloadComplete(ex);
throw;
}
Expand All @@ -462,6 +478,18 @@ public async Task StartDownloadsAsync(DownloadDiscoveryResult discoveryResult, E
_downloadException = ex;
_logger.Error(ex, "MultipartDownloadManager: Download failed");

// Cancel all remaining downloads immediately to prevent cascading timeout errors
try
{
internalCts.Cancel();
_logger.DebugFormat("MultipartDownloadManager: Cancelled all in-flight downloads due to error");
}
catch (ObjectDisposedException)
{
// CancellationTokenSource was already disposed, ignore
_logger.DebugFormat("MultipartDownloadManager: CancellationTokenSource already disposed during cancellation");
}

_dataHandler.OnDownloadComplete(ex);

// Dispose the CancellationTokenSource if background task was never started
Expand Down