Generate CompleteMultipartUpload

[peterrsongg]

Stacked PRs:

• ->Generate CompleteMultipartUpload #4209
• generate RestoreObject #4208
• generate ListMultipartUploads #4207
• Generate UpdateBucketMetadataTableConfiguration #4206
• Generate ListObjects #4205
• Generate DeleteBucketMetadataConfiguration #4204

---

Description

Generates CompleteMultipartUpload

Before in s3.customizations.json we were excluding "MultipartUploadand injectingPartETags. Since s3 was not generated, this change didn't really matter. This would only matter when we generate the simple methods for an operation from the s3.customizations.simpleforms.json but in this case there is no simple method that has PartETagsas a param. The issue with this approach is that if the service team updatesMultipartUploadand adds member, the now generated S3 will miss this update. Instead, we take the correct approach which is to flattenMultipartUploadso that its members are added to the top-level shape. This way, any updates toMultipartUpload` are generated as well.

Assembly Comparison Output (MpuObject size changed to a nulalble int) will call this out in changelog

AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CompleteMultipartUploadRequest/MethodRemoved: Missing method System.Int64 get_MpuObjectSize() in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompleteMultipartUploadRequest/MethodAdded: New method System.Nullable<System.Int64> get_MpuObjectSize() in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CompleteMultipartUploadRequest/MethodRemoved: Missing method System.Void set_MpuObjectSize(System.Int64) in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompleteMultipartUploadRequest/MethodAdded: New method System.Void set_MpuObjectSize(System.Nullable<System.Int64>) in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompletedMultipartUpload/TypeAdded: New type Amazon.S3.Model.CompletedMultipartUpload

Motivation and Context

Testing

DRY RUN: DRY_RUN-e581806f-264b-46d0-a331-1318e27c2273

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[dscpinheiro]

I haven't looked at all changes yet, but I had a similar comment in another PR: Why not use the IsSet method that already has this logic?

Also, the indentation on this method is really odd (and much harder to read than the hand-written file).

[peterrsongg]

that's a good question. For some reason the rest-xml payload marshalling logic doesn't use IsSet and does these if statements. This logic has existed before any of the S3 generation logic. I didn't want to change it because it is out of scop and will potentially affect all rest-xml services

[dscpinheiro]

Can you update the PR description explaining this? I don't follow why we were excluding something before but not it's in flattenShapes.

[peterrsongg]

added in the PR description