Skip to content

Conversation

@Reham77
Copy link

@Reham77 Reham77 commented Aug 19, 2024

Description of the issue

Add Integration tests for adding hyperpod resiliency metrics

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Ran the integration tests on a different branch

run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10441431020/job/28912567632
image

@Reham77 Reham77 requested a review from a team as a code owner August 19, 2024 10:10
@Reham77 Reham77 requested a review from movence August 19, 2024 10:10
@Reham77 Reham77 force-pushed the sagemaker branch 4 times, most recently from 247d44d to 464aec8 Compare August 19, 2024 20:23
@Reham77 Reham77 force-pushed the sagemaker branch 3 times, most recently from eac3bf3 to ead363b Compare August 22, 2024 12:08

eksTestRunners = []*test_runner.EKSTestRunner{
{
Runner: &AwsHyperPodTestRunner{test_runner.BaseTestRunner{DimensionFactory: factory}, "EKS_AWS_HYPERPOD", env},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant we add this to the list of runners in the existing test suite? Do we need a new test suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants