Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Dec 15, 2025

Issue #, if available:

Description of changes:

  • remove rushmash91

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- remove rushmash91
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm December 15, 2025 18:31
@ack-prow ack-prow bot added the approved label Dec 15, 2025
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Dec 15, 2025

/retest

1 similar comment
@knottnt
Copy link
Contributor Author

knottnt commented Dec 16, 2025

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Dec 16, 2025

/test documentdb-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Dec 16, 2025

/test apigatewayv2-controller-test

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow
Copy link

ack-prow bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

/retest

@ack-prow
Copy link

ack-prow bot commented Dec 17, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 6628671 link false /test verify-attribution
s3-olm-test 6628671 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor Author

knottnt commented Dec 17, 2025

/test apigatewayv2-controller-test

1 similar comment
@knottnt
Copy link
Contributor Author

knottnt commented Dec 17, 2025

/test apigatewayv2-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Dec 18, 2025

/retest documentdb-controller-test

@ack-prow
Copy link

ack-prow bot commented Dec 18, 2025

@knottnt: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test acm-controller-test
  • /test apigatewayv2-controller-test
  • /test cloudfront-controller-test
  • /test documentdb-controller-test
  • /test dynamodb-controller-test
  • /test ec2-controller-test
  • /test ecr-controller-test
  • /test efs-controller-test
  • /test eks-controller-test
  • /test eventbridge-controller-test
  • /test iam-controller-test
  • /test lambda-controller-test
  • /test pipes-controller-test
  • /test prometheusservice-controller-test
  • /test s3-controller-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test s3-olm-test
  • /test verify-attribution

Use /test all to run all jobs.

Details

In response to this:

/retest documentdb-controller-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knottnt
Copy link
Contributor Author

knottnt commented Dec 18, 2025

/test documentdb-controller-test

@ack-prow ack-prow bot merged commit 43713d4 into aws-controllers-k8s:main Dec 18, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants