Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Dec 17, 2025

Add a new executeBrowserTest utility in tests/e2e/utils/puppeteer.ts to
manage the Puppeteer browser lifecycle. This utility handles ng serve output
parsing for both Webpack and Vite, captures browser console errors, and provides
default assertions for page content to reduce test boilerplate.

Migrate the jit-prod E2E test to use this new utility as an initial validation
of the new infrastructure.

@clydin clydin force-pushed the e2e/protractor-cleanup branch 6 times, most recently from 7dfd74e to e35fef5 Compare December 18, 2025 15:05
Add a new `executeBrowserTest` utility in `tests/e2e/utils/puppeteer.ts` to
manage the Puppeteer browser lifecycle. This utility handles `ng serve` output
parsing for both Webpack and Vite, captures browser console errors, and provides
default assertions for page content to reduce test boilerplate.

Migrate the `jit-prod` E2E test to use this new utility as an initial validation
of the new infrastructure.
@clydin clydin force-pushed the e2e/protractor-cleanup branch from e35fef5 to c69739c Compare December 18, 2025 15:06
@clydin clydin added target: minor This PR is targeted for the next minor release and removed state: WIP labels Dec 18, 2025
@clydin clydin marked this pull request as ready for review December 18, 2025 15:06
Integrates `executeBrowserTest` into the `basic/serve` E2E test to
verify browser connectivity against a running HMR server.

Additionally, enables the `basic/serve` test in the Windows CI
workflow to ensure Puppeteer infrastructure stability on Windows.
@clydin clydin force-pushed the e2e/protractor-cleanup branch from cdd2400 to 020148e Compare December 18, 2025 15:54
@clydin clydin changed the title test: migrate E2E tests to puppeteer instead of protractor test: introduce Puppeteer infrastructure for E2E tests Dec 18, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant