Skip to content

Conversation

@salmanmkc
Copy link
Contributor

@salmanmkc salmanmkc commented Dec 11, 2025

Summary

This PR bumps @actions/cache from v4.x to v5.0.0.

Closes #1364

Why this change is needed

This update resolves the punycode deprecation warning that users are seeing in their workflow logs:

(node:1234) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Root Cause

The punycode module was deprecated in Node.js and is scheduled for removal. The previous version of @actions/cache (v4.x) had transitive dependencies that relied on the built-in punycode module, triggering this deprecation warning.

The Fix

@actions/cache v5.0.0 updates its dependency tree to use packages that no longer depend on the deprecated punycode module, eliminating the warning.

Changes

  • Updated @actions/cache from ^4.0.3 to ^5.0.0 in package.json
  • Rebuilt dist files with the updated dependency

Testing

  • Verify the punycode deprecation warning no longer appears in workflow logs
  • Ensure caching functionality works as expected

This update removes the punycode deprecation warning by updating to a version of @actions/cache that no longer depends on packages using the deprecated punycode module.
@salmanmkc salmanmkc requested a review from a team as a code owner December 11, 2025 20:18
Copilot AI review requested due to automatic review settings December 11, 2025 20:18
Regenerated license files to reflect the updated dependency tree after bumping @actions/cache to v5.0.0. This includes license information for new transitive dependencies and removes licenses for dependencies that are no longer used.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @actions/cache dependency from v4.1.0 to v5.0.0 to eliminate the Node.js punycode deprecation warning that appears in workflow logs. The punycode module has been deprecated in Node.js, and v5.0.0 of @actions/cache removes all transitive dependencies that relied on it by modernizing its dependency tree with updated Azure SDK packages and replacing deprecated libraries with current alternatives.

Key Changes:

  • Updated @actions/cache to v5.0.0, which includes major version bumps to its internal dependencies (@actions/core, @actions/exec, @actions/http-client, @actions/io all upgraded to v2.x within its dependency tree)
  • Replaced deprecated dependencies (@azure/ms-rest-js, abort-controller, form-data, event-target-shim) with modern alternatives (@azure/core-rest-pipeline, @typespec/ts-http-runtime, agent-base, http-proxy-agent, https-proxy-agent)
  • Updated documentation to reference actions/cache@v5 in usage examples

Reviewed changes

Copilot reviewed 25 out of 35 changed files in this pull request and generated no comments.

File Description
package.json Bumped @actions/cache from ^4.1.0 to ^5.0.0
package-lock.json Updated lockfile with new @actions/cache v5.0.0 and all transitive dependencies, including nested v2.x versions of @actions packages, upgraded Azure SDK packages (requiring Node.js >=20.0.0, compatible with project's >=24.0.0 requirement), and removal of deprecated packages
docs/advanced-usage.md Updated example usage from actions/cache@v4 to actions/cache@v5 to align with the dependency upgrade

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Mark @actions/http-client v2.2.1 and v3.0.0 as MIT license (correctly identified from LICENSE file content)
@salmanmkc
Copy link
Contributor Author

I should update a couple things first actually

@salmanmkc salmanmkc marked this pull request as draft December 12, 2025 14:27
@salmanmkc
Copy link
Contributor Author

I will be doing another release of cache, a v5.0.1 that will have the fix.

Before:

image

After

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v5: DeprecationWarning: The punycode module is deprecated

2 participants