Add .NET10.0 as TFM #3014
Add .NET10.0 as TFM #3014
Conversation
Can not reproduce it locally..
|
|
||
| Assert.Equal(0, count); | ||
| Assert.Equal([], output); | ||
| Assert.Equal(Array.Empty<byte>(), output); |
There was a problem hiding this comment.
We shouldn’t need to do this. Might be something to do with breaking changes re span overloads though.
There was a problem hiding this comment.
Yeah that came from new overloads
|
I got some problems on my machine.. One with libgdiplus and all the tests that use System.Drawing as a reference. The other is a Tiff test. --> #3017 When I use a tolerant comparer the test is green. Now I am only struggling with the FeatureTestRunner. Now going to look into it |
Tried to debug it on my side. On my machine DOTNET_EnableArm64AdvSimd=0 seems to not work. And on CI/CD we have a problem with DisableSSE .... strange... |
|
I made a small repro and created an issue for this in the runtime repo |
@JimBobSquarePants I got an answer there. The grouping changed and you can now only disable groups and not the individual ones.. What is your favorite way to go on with this? Introduce many #if NET10_0_OR_GREATER in the test code. Or disable the groups for net8 and net10? |
stefannikolei
force-pushed
the
sn/net10
branch
from
e4f9727 to
6aad0e7
Compare
tests/ImageSharp.Tests/Formats/WebP/ColorSpaceTransformUtilsTests.cs
Outdated
Show resolved
Hide resolved
tests/ImageSharp.Tests/Processing/Processors/Convolution/BokehBlurTest.cs
Outdated
Show resolved
Hide resolved
| <Choose> | ||
| <When Condition="$(SIXLABORS_TESTING_PREVIEW) == true"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net8.0;net9.0</TargetFrameworks> |
There was a problem hiding this comment.
@JimBobSquarePants Should we add .net10.0 to the "Otherwise" section too? So the next release would be build against both LTS versions of .NET?
There was a problem hiding this comment.
No, just 8. I want to always target a single framework
|
@stefannikolei @JimBobSquarePants When can we expect this to be released? |
You can use it today. Nothing stops you. This PR just enables testing against net10. You can always use a lib which targets a lower tfm. Just not the other way |
|
I'm just concerned that the current version of ImageSharp targets .NET 6 which is EOL. A bump to 8 or 10 would be appreciated. |
|
@silkfire that's not how nuget packages work the Target version of a package is the minimum version of the runtime we are compatible with and nothing to do with what version we run on (which is what the MS supported version stuff is about) that's based entirely on the version you target to compile/deploy your application against. In conclusion targets in nuget pacakges are about api compatibility only. Microsofts supported version of dotnet is about where you target/run your app and unrelated to this. This is true for all nuget packages btw not just ours. |
5 participants
No description provided.